duplicate code in WorkflowManager

Topics: Core
Feb 24, 2015 at 2:49 AM

line 72 to 79

       // if no activity record is matching the event, do nothing
        if (!startedWorkflows.Any() && !awaitingActivities.Any()) {
            return;
        }

        // if no activity record is matching the event, do nothing
        if (!startedWorkflows.Any() && !awaitingActivities.Any()) {
            return;
        }
Feb 24, 2015 at 4:26 PM
Hm! It seems wrong, but I am not 100% sure. Have you tried to remove it? Is everything working fine after that?
This lines of code are very old. I think these code was refactored in Commit 9d081860 (Feb 2013). Maybe a dev can tell you more - but anyway - nice catch ;).
Feb 24, 2015 at 5:42 PM
it is brand new code in 1.x
Coordinator
Feb 24, 2015 at 5:57 PM
Who the hell wrote this? Unacceptable !!!!

;)
Feb 24, 2015 at 6:51 PM
@infofromca: I meant that the code was written a long time before - but it is still there :)

@sebastian: Yeah, who the hell?? :D