Include latest version of Newtonsoft.Json


Is it possible to include the latest version of Newtonsoft.Json with 1.8.1?



CSADNT wrote May 6, 2014 at 7:30 PM

and jquery

urbanit wrote May 8, 2014 at 6:56 PM

and tinymce (on its way though)

JasperD wrote May 17, 2014 at 2:52 PM

Changeset 4761ec4 causes some build warnings.
Warning 4   Found conflicts between different versions of the same dependent assembly. In Visual Studio, double-click this warning (or select it and press Enter) to fix the conflicts; otherwise, add the following binding redirects to the "runtime" node in the application configuration file: <assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1"><dependentAssembly><assemblyIdentity name="Newtonsoft.Json" culture="neutral" publicKeyToken="30ad4fe6b2a6aeed" /><bindingRedirect oldVersion="" newVersion="" /></dependentAssembly></assemblyBinding> C:\Program Files (x86)\MSBuild\12.0\bin\Microsoft.Common.CurrentVersion.targets 1696    5   Orchard.Core

Jetski5822 wrote May 18, 2014 at 10:41 AM

I am not seeing this - I have even set my built output to verbose.

Have you done a clean and build?
What version of VS are you using?

I see only 2 build warning when using MSBuild and VS and have verified that these were seen before my commit.

JasperD wrote May 18, 2014 at 7:12 PM

I only get these warnings (63 of them actually) when compiling in VS 2013 Update 2 or using the VS 2013 command prompt. When using VS 2012, I just get two unrelated warnings about Orchard.Workflows.. It appears that Blend for VS 2013 (which includes a version of Newtonsoft.Json) interferes with MVC projects. I haven't found a way to solve this. Even when adding binding redirects and fixing all Newtonsoft.Json references to use version 6, I still get at least one warning from Upgrade project.

JasperD wrote May 19, 2014 at 8:16 AM

I managed to make all warnings go away using assembly redirects. Would you accept a PR?

agriffard wrote May 19, 2014 at 9:10 AM

Sure, please do. Integrating PR on Codeplex is currently the favorite hobby of Nick. It will be pleasure for him to accept it ;)

JasperD wrote May 19, 2014 at 10:49 AM

Yeah, I read about it and consider it really thoughtful of me to provide him with more pull requests.

Jetski5822 wrote May 19, 2014 at 11:27 AM

You guys!! - Sure send a PR and I will take a look.

I think its quite naughty of Visual Studio to have this. It seems as thought this is a Visual Studio bug.

JasperD wrote May 19, 2014 at 12:14 PM

Here it is: https://orchard.codeplex.com/SourceControl/network/forks/JasperD/json6vs12/contribution/6838

BTW: Thanks for processing so many pull request. I really appreciate it.