5

Resolved

In 1.7.x custom form permissions are broken

description

As the Permissions class requires the content types used as forms to have CustomFormPart attached, however the latter one is just used for custom form content items.

I think this is caused by this changeset: https://orchard.codeplex.com/SourceControl/changeset/068691af1194b0b98d7a74ce381820a8ae32ec1b

comments

pszmyd wrote Mar 4 at 6:07 PM

There is a bug indeed. I'll fix this one.

sebastienros wrote Mar 4 at 11:51 PM

If you change some code, please look at the history of this code, and if any previous change is linked to a bug, please ensure the bug is also still fixed.

arock3 wrote Mar 26 at 2:59 PM

Did this get fixed? If not is it on the 1.8 list?

pszmyd wrote Mar 26 at 3:58 PM

It is and will be fixed today.

sebastienros wrote Mar 26 at 4:44 PM

who will fix it ? It's not in my list.

sebastienros wrote Mar 26 at 4:50 PM

If someone tries to fix it, PLEASE take a look at the previous related bugs and ensure we are not regressing somewhere else. Look at the file history to see the related work.

pszmyd wrote Mar 26 at 6:18 PM

Yes, I'll ensure there is no regression. This is clearly a bug and I'll fix it.

sebastienros wrote Mar 26 at 6:57 PM

1.7.x, no merge, rebase instead

pszmyd wrote Mar 28 at 3:53 PM

Fixed in changeset df803b2301ff655530f6a7143782636308d12c50