When saving general site settings, the search settings are overridden with null values. I'm using the latest commit (0a097fe7b0c1) from the 1.x branch.
Steps to repro:
- Create a search index then go to the search settings page and select it.
- Click on the Settings link to open the general settings page and click save.
- Go back to the Search settings page. The search index you selected in step 1 is no longer selected.
I stepped through this in the debugger and found that in the SearchSettingsPartDriver the model is not being updated with previously saved values during the call to TryUpdateModel. This is causing an empty model to be saved which effectively overwrites any
previously saved search settings.
I'm wondering if this is a more pervasive issue too. I looked at the SearchSettingsPartDriver history and found no recent changes that account for the issue so I'm wondering if it's happening for other setting parts attached to the Site content item.