1

Resolved

IContentManager inconsistent on using ContentItem or IContent as method arguments

description

E.g. Create() accepts a ContentItem while GetItemMetadata() an IContent. I'd go with IContent everywhere as it's more flexible. This change wouldn't be a breaking one.

comments

Piedone wrote May 15, 2013 at 2:55 PM

Fixed in changeset 48ce2450dca2

rodpl wrote May 16, 2013 at 9:32 AM

This changeset broke ImportExport module

this code in ImportExportService.cs
        private XElement ExportContentItem(ContentItem contentItem) {
            // Call export handler for the item.
            return _orchardServices.ContentManager.Export(contentItem);
        }
... should change to ...
        private XElement ExportContentItem(IContent contentItem) {
            // Call export handler for the item.
            return _orchardServices.ContentManager.Export(contentItem);
        }

Piedone wrote May 16, 2013 at 10:24 AM

Why? ContentItem is IContent.

sfmskywalker wrote Mar 28 at 12:28 AM

Fixed in changeset 6ca76c68bb14d56ff2989d42d9d966c665699150