This project is read-only.


IRouteProvider should be ISingletonDependency


It seems to me that it's unnecessary that they are of type IDependency when the routes provided by them shouldn't change during shell lifetime. DefaultAliasService injects a collection of route providers and this practically means that all route providers will be instantiated for every request.
Closed Apr 9, 2013 at 9:18 PM by sebastienros
No benefit in having a singleton here


sebastienros wrote Apr 9, 2013 at 9:12 PM

Is there any reason the routes would change per request ?