2

Resolved

Fixes after migration to JQuery 1.9.1 for v1.7

description

Broken functionality after migration to jQuery 1.9.1
  1. live(...) method removed in version 1.9 of jQuery, thus all references to it should be replaced to delegate(...)
  2. Taxonomies module: Add reference to menu jQuery UI plugin, autocomplete plugin depended on it.
See attached patch_changeset_0458f55cc02e.txt for fixes.

file attachments

comments

JasperD wrote Mar 31, 2013 at 12:27 AM

It doesn't make sense to use delegate instead of live because on supersedes both as of JQuery 1.7.

JasperD wrote Mar 31, 2013 at 12:45 AM

I've to correct myself. It does make sense because delegate is supported by jQuery 1.9 and live is not. Nevertheless, I think it would be better to replace delegate/live with on because it's more future proof.

BertrandLeRoy wrote Mar 31, 2013 at 7:37 AM

I concur: "on" should be used everywhere.

CSADNT wrote Mar 31, 2013 at 10:30 AM

This was my original choice, I would say that UI 1.10 has been working nicely since I installed it and is solid, bringing many new features (for IE10 and chrome).

CSADNT wrote Apr 1, 2013 at 1:32 PM

Many things broken actually due to related jQuery not updated.
I have provided all these files in my proposal, they were not using JQuery UI 1.10 feature, so they are Ok for this upgrade.
http://orchard.codeplex.com/workitem/19434

CSADNT wrote Apr 1, 2013 at 2:52 PM

Proposed patch for live ->on and domain integration

sebastienros wrote Apr 2, 2013 at 5:47 PM

Fixed in chageset 2de1c1a2ff92