CommonPartHandler.ContentTypeWithACommonPart() could use content type definition from context


Instead of fetching the content type definition from the ContentDefinitionManager instance for checking whether CommonPart is attached to the current type or not it could use the definition already loaded in the ActivatingContentContext object. Not sure if the current implementation causes any overhead, but it's a needless call anyway.


Piedone wrote May 15, 2013 at 2:59 PM

Fixed in changeset 2e961eac34d1

sebastienros wrote May 15, 2013 at 6:38 PM

Backed out as was causing unit tests to fail, and analysis showed it didn't cause any overhead, and the content type is already loaded to fetch the ContentDefinition itself

sfmskywalker wrote Mar 28 at 12:28 AM

Fixed in changeset 3fef593881cfc6fd0b7d1d0efce0df04c9c0c512