UX improvement: Saving a rule shouldn't disable it


Currently, if you save a rule by clicking on the "Save" button, the rule will be disabled after the changes
are saved (regardless of the state of the rule prior to saving it). When the page reloads,
the "Save and enable" button appears, with which you can enable the rule of course.

I think it should rather work like this:
  • if the rule is disabled, two buttons should be displayed: "Save" (or "Save and leave disabled")
    and "Save and enable")
  • if the rule is enabled, only one button, "Save" should be available.

file attachments


Piedone wrote Nov 14, 2012 at 1:35 PM

For the second option I would probably have "Save and disable" as well. Anyway, I'd also have regular saving as the default for an already enabled rule. Currently "Save" is misleading as it also disables, but this is not indicated (this behaviour can lead to features not disabled on purpose).

sebastienros wrote Nov 14, 2012 at 5:46 PM

It's not supposed to disable it ... that's a bug

nightwolf226 wrote Nov 15, 2012 at 7:20 AM

Ah I see. So the problem is that the view doesn't store the enabled/disabled state of the rule and when saving, the viewmodel's "Enabled" field is of course initailized to false. So I added a hidden field to the view, it works now. I think the "Save" and "Save and enable" buttons are okay like this then.
I'm attaching the patch.

sebastienros wrote Mar 6, 2013 at 9:40 PM

Fixed in changeset d578277802bc

sfmskywalker wrote Mar 28 at 12:28 AM

Fixed in changeset 417d3944354f60d05e20e5e818bd04f04b4ff6a6